-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first Korean cookbook #134
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
View / edit / reply to this conversation on ReviewNB merveenoyan commented on 2024-07-03T11:50:00Z Can we find a Korean one for consistency? |
View / edit / reply to this conversation on ReviewNB merveenoyan commented on 2024-07-03T11:50:00Z no need to make numbered headings |
View / edit / reply to this conversation on ReviewNB merveenoyan commented on 2024-07-03T11:50:01Z maybe printing a few as an example would look better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very comprehensive, gomapseumnida! 🤗
Would be great for a Korean speaking reviewer to skim through it. Left two small nits, reviewed through autotranslation in browser.
View / edit / reply to this conversation on ReviewNB jungnerd commented on 2024-07-04T01:54:29Z 저장: 성된 임베딩 ... There is a typo. I think '저장: 완성된 임베딩 ...' is the correct sentence. |
Thank you all for your reviews! @merveenoyan @jungnerd ❤️ |
Co-authored-by: Jihun Lim <[email protected]>
@merveenoyan, @stevhliu |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for kicking off Korean contributions for the cookbook! 🤗
What does this PR do?
This PR represents the first step in adding Korean content to the Open-Source AI Cookbook. The main changes are as follows:
Who can review?
@jungnerd, @heuristicwave, @junejae, @nuatmochoi
@merveenoyan, @stevhliu.