Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first Korean cookbook #134

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Add first Korean cookbook #134

merged 4 commits into from
Sep 13, 2024

Conversation

harheem
Copy link
Contributor

@harheem harheem commented Jul 1, 2024 •
edited
Loading

What does this PR do?

This PR represents the first step in adding Korean content to the Open-Source AI Cookbook. The main changes are as follows:

  1. Created 'ko' directory: A new 'ko' directory has been added under the notebooks folder to house Korean content.
  2. Added Korean Advanced RAG notebook: This notebook introduces advanced RAG (Retrieval-Augmented Generation) techniques to Korean-speaking users.
  3. Created table of contents and index files:
    • Generated the notebooks/ko/_toctree.yml file.
    • Added the notebooks/ko/index.md file.
  4. Updated workflow files: Added the 'ko' language code to build_documentation.yml and build_pr_documentation.yml files in the .github/workflows folder.

Who can review?

@jungnerd, @heuristicwave, @junejae, @nuatmochoi
@merveenoyan, @stevhliu.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@review-notebook-app Review Notebook App
Copy link

review-notebook-app bot commented Jul 3, 2024 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

merveenoyan commented on 2024-07-03T11:50:00Z
----------------------------------------------------------------

Can we find a Korean one for consistency?


@review-notebook-app Review Notebook App
Copy link

review-notebook-app bot commented Jul 3, 2024 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

merveenoyan commented on 2024-07-03T11:50:00Z
----------------------------------------------------------------

no need to make numbered headings

@review-notebook-app Review Notebook App
Copy link

review-notebook-app bot commented Jul 3, 2024 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

merveenoyan commented on 2024-07-03T11:50:01Z
----------------------------------------------------------------

maybe printing a few as an example would look better

merveenoyan
merveenoyan reviewed Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@merveenoyan merveenoyan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very comprehensive, gomapseumnida! 🤗
Would be great for a Korean speaking reviewer to skim through it. Left two small nits, reviewed through autotranslation in browser.

@review-notebook-app Review Notebook App
Copy link

review-notebook-app bot commented Jul 4, 2024 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

jungnerd commented on 2024-07-04T01:54:29Z
----------------------------------------------------------------

저장: 성된 임베딩 ...

There is a typo.

I think '저장: 완성된 임베딩 ...' is the correct sentence.

@harheem
Copy link
Contributor Author

harheem commented Jul 18, 2024 •
edited
Loading

Thank you all for your reviews! @merveenoyan @jungnerd ❤️
I've incorporated the feedback you provided through ReviewNB.

@harheem
Copy link
Contributor Author

harheem commented Sep 12, 2024

@merveenoyan, @stevhliu
Would you mind considering merging this PR? 😊

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

stevhliu
stevhliu approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for kicking off Korean contributions for the cookbook! 🤗

@stevhliu stevhliu merged commit 5c04d93 into huggingface:main Sep 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heuristicwave heuristicwave heuristicwave left review comments

@merveenoyan merveenoyan merveenoyan left review comments

@stevhliu stevhliu stevhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harheem @HuggingFaceDocBuilderDev @heuristicwave @merveenoyan @stevhliu